D27760: WIP | Added BatchMoveJob

emateli added inline comments. INLINE COMMENTS > batchmovejobtest.cpp:89 > +KIO::Job *job = KIO::batchMove(items); > + > KIO::FileUndoManager::self()->recordJob(KIO::FileUndoManager::CommandType::BatchMove, > QList{}, QUrl(), job); > +job->setUiDelegate(nullptr); @dfaure

D27760: WIP | Added BatchMoveJob

dfaure added a comment. Looks good, just a few things. INLINE COMMENTS > batchmovejobtest.cpp:91 > +job->setUiDelegate(nullptr); > +QSignalSpy spy(job, SIGNAL(fileMoved(QUrl, QUrl))); > + Use newer syntax &KIO::BatchMoveJob::fileMoved? > batchmovejobtest.cpp:104 > +

D27760: WIP | Added BatchMoveJob

ngraham added a comment. The general concept seems sane to me, but let's make sure @dfaure agrees. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27760 To: emateli, dfaure, ngraham Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, brun

D27760: WIP | Added BatchMoveJob

emateli added a comment. In that it supports moving them to different directories but as well as moving them with a different name. This operation is to allow also batch renaming of items. See this patch for more details: D14631 eg: BatchMove {`a.txt

D27760: WIP | Added BatchMoveJob

nicolasfella added a comment. What's the difference to the job you get with KIO::move with a list of urls? https://api.kde.org/frameworks/kio/html/namespaceKIO.html#a20da0b04660f834de30f9440673f6d5e REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27760 To: emateli, dfau

D27760: WIP | Added BatchMoveJob

emateli retitled this revision from "Added BatchMoveJob" to "WIP | Added BatchMoveJob". emateli edited the summary of this revision. emateli added reviewers: dfaure, ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27760 To: emateli, dfaure, ngraham Cc: kde-framewor