D27794: Fix symlink problem because of using relative path instead of full path

2020-03-04 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. Yes, the generation of relative symlinks is intentional and necessary. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27794 To: usta, ngraham, kossebau, ndavis Cc: kde-frameworks-devel,

D27794: Fix symlink problem because of using relative path instead of full path

2020-03-02 Thread Noah Davis
ndavis added a comment. Example: F8146162: Screenshot_20200302_233811.PNG I renamed the original breeze-icons repo to breeze-icons2 and the symlinks broke because they were pointing to the source folder instead of the installation folder.

D27794: Fix symlink problem because of using relative path instead of full path

2020-03-02 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Relative links are actually necessary. Otherwise, they won't work when the source repository isn't present. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27794: Fix symlink problem because of using relative path instead of full path

2020-03-02 Thread Ömer Fadıl Usta
usta created this revision. usta added reviewers: ngraham, kossebau, ndavis. usta added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. usta requested review of this revision. REVISION SUMMARY generate script was trying to read the source of symlinked files base but it