D27811: [KConfigGui] Check font weight when clearing styleName property

2020-03-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R237:ec9522ae73ff: [KConfigGui] Check font weight when clearing styleName property (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27811?vs=7687

D27811: [KConfigGui] Check font weight when clearing styleName property

2020-03-06 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH l-kconfiggui (branched from master) REVISION DETAIL https://phabricator.kde.org/D27811 To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport Cc: kde-fra

D27811: [KConfigGui] Check font weight when clearing styleName property

2020-03-05 Thread Kevin Ottens
ervin added a comment. In D27811#622916 , @ahmadsamir wrote: > In D27811#622885 , @ervin wrote: > > > This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in th

D27811: [KConfigGui] Check font weight when clearing styleName property

2020-03-05 Thread Ahmad Samir
ahmadsamir added a comment. In D27811#622885 , @ervin wrote: > This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss. Well this one is the tip of

D27811: [KConfigGui] Check font weight when clearing styleName property

2020-03-05 Thread Kevin Ottens
ervin added a comment. This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27811 To: ahmadsamir, #frameworks, dfaure, david

D27811: [KConfigGui] Check font weight when clearing styleName property

2020-03-05 Thread Kevin Ottens
ervin added a reviewer: bport. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27811 To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27811: [KConfigGui] Check font weight when clearing styleName property

2020-03-03 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, davidedmundson, cfeck, ervin, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This is an addendum for commit a2774ff5b41987c3919a9e