D27910: Make sure warning output is enabled before testing if the correct warning is printed

dfaure added a comment. I like your first suggestion. I don't like the second one, because QT_LOGGING_RULES is used (by at least CI and myself) to enable *more* debug output. unsetenv would break that. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D27910 To:

D27910: Make sure warning output is enabled before testing if the correct warning is printed

sandsmark abandoned this revision. sandsmark added a comment. In D27910#632041 , @dfaure wrote: > Note that in both cases the env var QT_LOGGING_RULES would break the unittest anyway... so yeah it's only about qtlogging.ini which we can easily s

D27910: Make sure warning output is enabled before testing if the correct warning is printed

dfaure added a comment. Note that in both cases the env var QT_LOGGING_RULES would break the unittest anyway... so yeah it's only about qtlogging.ini which we can easily skip with test mode. Here's my suggested fix: D28189 @apol Warnings are enab

D27910: Make sure warning output is enabled before testing if the correct warning is printed

dfaure added a comment. I suggest a better solution: QStandardPaths::setTestModeEnabled(true) in initTestCase(). Then the user settings won't interfere with the unittest. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D27910 To: sandsmark, dfaure Cc: apol, kde

D27910: Make sure warning output is enabled before testing if the correct warning is printed

apol added a comment. Is it passing on the CI because somehow we enable warnings on there? https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.13/60/testReport/ REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D27910 To: sandsmark, dfaure Cc: ap

D27910: Make sure warning output is enabled before testing if the correct warning is printed

sandsmark updated this revision to Diff 77165. sandsmark added a comment. Forgot that differential doesn't like patches created when git has noprefix turned on. REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27910?vs=77164&id=77165 REVISION DETAIL http

D27910: Make sure warning output is enabled before testing if the correct warning is printed

sandsmark created this revision. sandsmark added a reviewer: dfaure. sandsmark added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. sandsmark requested review of this revision. REVISION SUMMARY A couple of the tests check for specific warning