D27913: Icons for emoji categories

guoyunhe edited the summary of this revision. guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27913 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27913: Icons for emoji categories

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27913 AFFECTED FILES icons-dark/action

D27913: Icons for emoji categories

guoyunhe added a dependent revision: D27915: Use breeze icons for categories. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27913 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27913: Icons for emoji categories

ngraham added a comment. If we do this, then won't the category icons look different from the actual emoji icons when using a font where the emojis look different? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27913 To: guoyunhe, #breeze Cc: ngraham, kde-fram

D27913: Icons for emoji categories

guoyunhe added a comment. In D27913#624159 , @ngraham wrote: > If we do this, then won't the category icons look different from the actual emoji icons when using a font where the emojis look different? Hi @ngraham , the main idea is to ma

D27913: Icons for emoji categories

ngraham added a comment. It seems like there are two goals here: - Use monochrome icons - Be able to choose which icon is shown in the sidebar. I don't have strong opinions about #1, but I agree that #2 is useful. However do we have to use breeze icons for this? Couldn't we adjust

D27913: Icons for emoji categories

apol added a comment. In D27913#624850 , @ngraham wrote: > It seems like there are two goals here: > > - Use monochrome icons > - Be able to choose which icon is shown in the sidebar. > > I don't have strong opinions about #1, but I ag

D27913: Icons for emoji categories

guoyunhe added a comment. D27915 is for the change. The ibus dict comes with untranslated categories name. The category names may change. But it seems the dict hasn't been updated that often. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabr

D27913: Icons for emoji categories

apol added a comment. In D27913#624990 , @guoyunhe wrote: > D27915 is for the change. The ibus dict comes with untranslated categories name. The category names may change. But it seems the dict hasn't been up

D27913: Icons for emoji categories

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think I'll want to update some of these icons in the future, particularly the animal icon since that's using another project's mascot. Still, I don't think it'll be a problem since the Te

D27913: Icons for emoji categories

This revision was automatically updated to reflect the committed changes. Closed by commit R266:90ed6fdf4317: Icons for emoji categories (authored by Guo Yunhe ). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27913?vs=77169&id=77393 RE