This revision was automatically updated to reflect the committed changes.
Closed by commit R307:b6b86f158254: PersonsModel: Fix PersonVCardRole (authored
by jbbgameich).
REPOSITORY
R307 KPeople
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28110?vs=77869&id=77870
REVISION DETAIL
nicolasfella accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R307 KPeople
BRANCH
fix-personsmodel-vcard (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28110
To: jbbgameich, apol, nicolasfella
Cc: nicolasfella, kde-frameworks-devel,
jbbgameich updated this revision to Diff 77869.
jbbgameich added a comment.
Use AbstractContact::VCardProperty
REPOSITORY
R307 KPeople
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28110?vs=77868&id=77869
BRANCH
fix-personsmodel-vcard (branched from master)
REVISION DETAIL
nicolasfella added inline comments.
INLINE COMMENTS
> personsmodel.cpp:186
> case PersonsModel::PersonVCardRole:
> -return QVariant::fromValue(person);
> +return person->customProperty(QStringLiteral("vcard"));
> case PersonsModel::ContactsVCardRole:
Use AbstractContact
jbbgameich created this revision.
jbbgameich added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.
REPOSITORY
R307 KPeople
BRANCH
fix-personsmodel-vcard (branched from master)
REVISION DETAIL
