D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. In D28169#631893 , @ahmadsamir wrote: > Yesterday, I did try tweaking XDG_DATA_DIRS to make it find the .desktop file without it being in /usr/share/applications It's more portable to use QStandardPaths test mode

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir abandoned this revision. ahmadsamir added a comment. In D28169#631885 , @dfaure wrote: > OK, it's fixed now, after 3 commits :-) > You can drop this change, it's better that CI actually tests the code. [..] Yesterday, I did

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. OK, it's fixed now, after 3 commits :-) You can drop this change, it's better that CI actually tests the code. Thanks for your help though (with this, and with everything else - very much appreciated) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. The bug is that, after the fuse dbus call fails, we can't just blindly go to kioexec. It depends on `supported`. ktelnetservice supports ssh, so we don't need kioexec. Will rework... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28169 To: ahma

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. In D28169#631841 , @ahmadsamir wrote: > In D28169#631809 , @dfaure wrote: > > > Ah, we had tried already to make it work uninstalled. > > > > The actual way to do that wou

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir added a comment. In D28169#631809 , @dfaure wrote: > Ah, we had tried already to make it work uninstalled. > > The actual way to do that would be to copy that desktop file into a local ApplicationsLocation. I'll do that, I just did

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir updated this revision to Diff 78156. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28169?vs=78152&id=78156 BRANCH l-krun-ssh-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28169 AFFE

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

dfaure added a comment. Ah, we had tried already to make it work uninstalled. The actual way to do that would be to copy that desktop file into a local ApplicationsLocation. I'll do that, I just did something similar in KParts. REPOSITORY R241 KIO REVISION DETAIL https://phabricator

D28169: [krununittest] Skip the test if ktelnetservice5{, .desktop} isn't found

ahmadsamir updated this revision to Diff 78152. ahmadsamir retitled this revision from "[DesktopExecParser] Let the service open protocols is claims to support" to "[krununittest] Skip the test if ktelnetservice5{,.desktop} isn't found". ahmadsamir edited the test plan for this revision. ahmadsam