This revision was automatically updated to reflect the committed changes.
Closed by commit R275:37754045e2b8: [KSortFilterProxyModel QML] Make
invalidateFilter public (authored by broulik).
REPOSITORY
R275 KItemModels
CHANGES SINCE LAST UPDATE
broulik updated this revision to Diff 78227.
broulik added a comment.
- Add docs
REPOSITORY
R275 KItemModels
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28197?vs=78206=78227
REVISION DETAIL
https://phabricator.kde.org/D28197
AFFECTED FILES
iasensio added a dependent revision: D28152: [RFC] KWinRules KCM Redesign.
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D28197
To: broulik, ahiemstra, davidedmundson, iasensio, kmaterka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
iasensio accepted this revision.
iasensio added a comment.
It's working nicely, thanks!
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D28197
To: broulik, ahiemstra, davidedmundson, iasensio, kmaterka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
davidedmundson added inline comments.
INLINE COMMENTS
> ksortfilterproxymodel.h:126
> +public Q_SLOTS:
> +void invalidateFilter();
> +
Could you add a line of docs that say this is relevant if you have a set filter
callback, but not needed when just changing the properties
REPOSITORY
kmaterka accepted this revision.
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D28197
To: broulik, ahiemstra, davidedmundson, iasensio, kmaterka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D28197
To: broulik, ahiemstra, davidedmundson, iasensio, kmaterka
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
broulik created this revision.
broulik added reviewers: ahiemstra, davidedmundson, iasensio, kmaterka.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
`invalidate` is, so I don't see why
