This revision was automatically updated to reflect the committed changes.
Closed by commit R293:bcb5950e958e: [Inotify] Remove dead/duplicate code
(authored by bruns).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D28324?vs=78600=79582#toc
REPOSITORY
R293 Baloo
CHANGES SINCE LAST
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
I think this is fine.
REPOSITORY
R293 Baloo
BRANCH
submit
REVISION DETAIL
https://phabricator.kde.org/D28324
To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel,
bruns marked 5 inline comments as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28324
To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> pino wrote in kinotify.cpp:350
> no, an assert is sort of "program by contract": you make it clear that this
> situation ought to not happen, and it if does, at least some people may
> notice that
>
> >
pino added inline comments.
INLINE COMMENTS
> bruns wrote in kinotify.cpp:350
> asserts are IMHO pointless, nobody enables them, but it clutters the code.
> Anyone touching the code should and has to read the man pages etc anyway.
no, an assert is sort of "program by contract": you make it
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> pino wrote in kinotify.cpp:350
> then add an assert for this case, referencing the documentation?
asserts are IMHO pointless, nobody enables them, but it clutters the code.
Anyone touching the code should
pino added inline comments.
INLINE COMMENTS
> bruns wrote in kinotify.cpp:350
> man inotify
>
> > IN_Q_OVERFLOW
> > Event queue overflowed (wd is -1 for this event).
then add an assert for this case, referencing the documentation?
REPOSITORY
R293 Baloo
REVISION DETAIL
bruns marked an inline comment as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28324
To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> pino wrote in kinotify.cpp:350
> ... but only also if wd is < 0
man inotify
> IN_Q_OVERFLOW
> Event queue overflowed (wd is -1 for this event).
REPOSITORY
R293 Baloo
REVISION DETAIL
pino added inline comments.
INLINE COMMENTS
> bruns wrote in kinotify.cpp:350
> First check is here
... but only also if wd is < 0
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28324
To: bruns, #baloo, ngraham
Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs,
bruns added inline comments.
INLINE COMMENTS
> kinotify.cpp:350
> }
>
> // the event name only contains an interesting value if we get an
> event for a file/folder inside
First check is here
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28324
To:
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
event->mask & EventQueueOverflow is already checked once early in the
12 matches
Mail list logo