This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b071a8b53fdb: [Inotify] Call QFile::decode only in a
single place (authored by bruns).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D28325?vs=78606&id=78672#toc
REPOSITORY
R293 Baloo
CHANG
kossebau added inline comments.
INLINE COMMENTS
> kinotify.cpp:368
> +uint32_t fileEvents = EventAll & ~(EventMoveFrom |
> EventQueueOverflow | EventIgnored);
> +const QString fname = event->mask & fileEvents ?
> QFile::decodeName(path) : QString();
> +
For better code readabil
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28325
To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, GB_2, domson, ashaposh
bruns marked an inline comment as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28325
To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
ngr
bruns updated this revision to Diff 78606.
bruns added a comment.
simplify condition, whitespace
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28325?vs=78601&id=78606
REVISION DETAIL
https://phabricator.kde.org/D28325
AFFECTED FILES
src/file/kinotify.c
bruns marked an inline comment as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28325
To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
ngr
bruns added inline comments.
INLINE COMMENTS
> apol wrote in kinotify.cpp:371
> This conditional looks off, maybe it would make sense to have an intermediate
> class to decide when to initialize it?
>
> Something like this:
>
> template
> class Delayed
> {
> public:
> Delayed(st
apol added inline comments.
INLINE COMMENTS
> kinotify.cpp:365
>
> + // All events which need a decoded path, i.e. everything
> + // but EventMoveFrom | EventQueueOverflow | EventIgnored
Indentation looks off.
> kinotify.cpp:371
> +EventMoveTo | EventOpen | EventUnmount;
>
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Most events need a decoded path, so move it to the front. As only one
flag pe
