D28406: Fix sonnet autodetect test failure

waqar added a comment. In D28406#644383 , @dfaure wrote: > @waqar ping? What do you think about my suggestion? If you agree, can you update the patch? Sorry I have been really busy at work, and overlooked the last email. I did plan to wo

D28406: Fix sonnet autodetect test failure

dfaure added a comment. I pushed it with my changes included. The test is fixed: https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/sonnet/job/kf5-qt5%20SUSEQt5.12/ REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: dfaure, waqar Cc: dfaur

D28406: Fix sonnet autodetect test failure

dfaure commandeered this revision. dfaure edited reviewers, added: waqar; removed: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: dfaure, waqar Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28406: Fix sonnet autodetect test failure

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R246:78450298149e: Fix sonnet autodetect test failure (authored by waqar, committed by dfaure). CHANGED PRIOR TO COMMIT

D28406: Fix sonnet autodetect test failure

dfaure added a comment. @waqar ping? What do you think about my suggestion? If you agree, can you update the patch? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waqar, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28406: Fix sonnet autodetect test failure

dfaure requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waqar, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28406: Fix sonnet autodetect test failure

dfaure added a reviewer: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waqar, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28406: Fix sonnet autodetect test failure

dfaure added a comment. Well if the test is tolerant about correctLangCode, it might as well not require a specific variant upfront. What about replacing en_US-large with en_US and de_DE_frami with de_DE in SonnetAutoDetectTest::autodetect_data? This makes the first test pass for me (I

D28406: Fix sonnet autodetect test failure

waqar added a comment. In D28406#637359 , @dfaure wrote: > I'm no expert in this stuff, but here's my feedback > > 1. on my own system (!= CI), all three tests were failing before, due to finding en_AU-variant_1, en_AU-variant_1 and "". > 2

D28406: Fix sonnet autodetect test failure

waqar added inline comments. INLINE COMMENTS > dfaure wrote in test_autodetect.cpp:51 > This will have an effect on *other* instances of the Speller class? Yes, behind the scenes it is saved in the Settings. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waq

D28406: Fix sonnet autodetect test failure

apol retitled this revision from ""Fix sonnet autodetect test failure"" to "Fix sonnet autodetect test failure". REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waqar Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28406: "Fix sonnet autodetect test failure"

dfaure added a comment. I'm no expert in this stuff, but here's my feedback 1. on my own system (!= CI), all three tests were failing before, due to finding en_AU-variant_1, en_AU-variant_1 and "". 2. now the test passes locally, but because all tests are skipped SKIP : SonnetAut

D28406: "Fix sonnet autodetect test failure"

waqar created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. waqar requested review of this revision. REPOSITORY R246 Sonnet BRANCH fix-autodetect-test (branched from master) REVISION DETAIL https://phabricator.kde.org/D28406 AFFECTED F