D28444: WIP/RFC: Add ECMCargo module

cblack updated this revision to Diff 79430. cblack added a comment. Address feedback REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28444?vs=78925=79430 BRANCH cblack/cargo-integration REVISION DETAIL https://phabricator.kde.org/D28444

D28444: WIP/RFC: Add ECMCargo module

IlyaBizyaev added a comment. In D28444#639020 , @cblack wrote: > CMake needs to know what files Cargo wants to build in order to invoke it only when Rust files change. There's no reason to invoke Cargo every time `make` is ran when CMake has

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638988 , @IlyaBizyaev wrote: > In D28444#638877 , @cblack wrote: > > > CMake needs to know when the Rust source has changed so it can rebuild it > > > Changes

D28444: WIP/RFC: Add ECMCargo module

IlyaBizyaev added a comment. In D28444#638877 , @cblack wrote: > CMake needs to know when the Rust source has changed so it can rebuild it Changes to Rust code need to be tracked by Cargo, not by CMake REPOSITORY R240 Extra CMake

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638540 , @IlyaBizyaev wrote: > In D28444#638430 , @cblack wrote: > > > more than half of Ikona's CMakeLists.txt is boilerplate dedicated to integrating Rust with

D28444: WIP/RFC: Add ECMCargo module

IlyaBizyaev added a comment. In D28444#638430 , @cblack wrote: > more than half of Ikona's CMakeLists.txt is boilerplate dedicated to integrating Rust with the rest of the project I don't understand why your function needs a list of Rust

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638435 , @apol wrote: > Will this make all the boilerplate in ikona disappear? It'll bring it down to the same level as everything else. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D28444: WIP/RFC: Add ECMCargo module

apol added a comment. > I feel like one of the reasons KDE doesn't use Rust more is that using it in the build system side is pain. Case in point: more than half of Ikona's CMakeLists.txt is boilerplate dedicated to integrating Rust with the rest of the project. I'd like to get this in ECM

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638428 , @apol wrote: > I wonder if this is covering a very widespread use-case. If there's just one application that needs it, it could make sense to keep it there and once it's polished, we put it in ECM to

D28444: WIP/RFC: Add ECMCargo module

apol added a comment. Code per se looks okay, not that I've ever used a rust workspace. It does need documentation though. See other ECM modules to see what it looks like. I wonder if this is covering a very widespread use-case. If there's just one application that needs it, it

D28444: WIP/RFC: Add ECMCargo module

IlyaBizyaev added a comment. I'm not good at CMake modules, but maybe this code (which I used in a project) is useful: https://github.com/Devolutions/CMakeRust REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28444 To: cblack, #frameworks,

D28444: WIP/RFC: Add ECMCargo module

cblack created this revision. cblack added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY The ECMCargo module allows for easy usage