ahmadsamir added inline comments.
INLINE COMMENTS
> kcmoduleloader.cpp:164
> +
> +QVariantList args2(args.cbegin(), args.cend());
> +
Hello. This breaks the build for Qt 5.12 on the CI, (the min. required version
in KF is still 5.12):
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf
ahmadsamir closed this revision.
ahmadsamir added a comment.
Has been moved to
https://invent.kde.org/frameworks/kcmutils/-/merge_requests/10
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D28460
To: bport, #plasma, ervin
Cc: ahmadsamir, meven, broulik, kde-framewo
bport retitled this revision from "Add KCModuleDada as base class for plugin"
to "Add KCModuleData as base class for plugin".
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D28460
To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,
meven added inline comments.
INLINE COMMENTS
> kcmoduledata.h:35
> + *
> + * @since 5.70
> + */
@since 5.71
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D28460
To: bport, #plasma, ervin
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,
meven added inline comments.
INLINE COMMENTS
> kcmoduleloader.h:113
> + *
> + * @since 5.69
> + */
@since 5.71
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D28460
To: bport, #plasma, ervin
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngrah
