D28682: export done signal in filecontentindexer

astippich updated this revision to Diff 79751. astippich added a comment. - rename signal REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28682?vs=79657&id=79751 BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 AFFECTED FILES src

D28682: export done signal in filecontentindexer

astippich added a comment. How about committedBatch so that it's clear that they have been committed to the database? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00

D28682: export done signal in filecontentindexer

bruns added a comment. Regarding API, `done` is a little bit vague. Can you rename it to `finishedBatch` (or come up with a better name). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikha

D28682: export done signal in filecontentindexer

bruns added a comment. In D28682#644914 , @astippich wrote: > Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call. Lets keep the API as small as possible ... REPOSI

D28682: export done signal in filecontentindexer

astippich added a comment. Then it's fine from my application point of view. I can add a corresponding start signal for convenience, though. Your call. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-deve

D28682: export done signal in filecontentindexer

bruns added a comment. In D28682#644430 , @astippich wrote: > In D28682#644414 , @bruns wrote: > > > In general fine for me. > > > > How will Elisa deal with the indexer maybe crashing inbetween?

D28682: export done signal in filecontentindexer

astippich added a comment. > Quoted Text > >> ! In D28682#644412 , @mgallien wrote: > > This is the reason why it is so slow in Elisa? Do you mean slow for picking up changes in files? Then yes. This happens when a track is modified wh

D28682: export done signal in filecontentindexer

bruns added a comment. In general fine for me. How will Elisa deal with the indexer maybe crashing inbetween? Do we also need a signal for a batch start? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-framewor

D28682: export done signal in filecontentindexer

mgallien added a comment. This is the reason why it is so slow in Elisa? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashapo

D28682: export done signal in filecontentindexer

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Applications can subsribe for new files being indexed by baloo via