D28874: Taiwanese holidays

shrapnel added a comment. I just wanted to say thank you to everybody for taking the time. Taiwan is available in the clock/calendar settings now, really cool! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: nhiga,

D28874: Taiwanese holidays

nhiga added a comment. By the way, the holiday file for People's Republic of China (i.e. mainland China) also needs update too because the dates of Lunar calendar based holidays are only available for 2009. The comment in the file says "these have to wait for lunar calendar support", but

D28874: Taiwanese holidays

nhiga added a comment. Thank you for your attempt to add Taiwanese holidays to KDE. However, I am afraid that this patch has to be reviewed again. The dates for some holidays (including, but not limited to, Spring Festival (also known as "Lunar New Year") and the Mid-Autumn Festival)

D28874: Taiwanese holidays

This revision was automatically updated to reflect the committed changes. Closed by commit R175:4d947fa1ca59: Taiwanese holidays (authored by shrapnel, committed by cgiboudeaux). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80415=80451 REVISION

D28874: Taiwanese holidays

ngraham added a comment. Sure, I can do it. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: ngraham, winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28874: Taiwanese holidays

winterz added a comment. In D28874#650661 , @ngraham wrote: > Do you not have commit access? I thought you were the maintainer based on the repo's history! Yes of course. I'm asking for assistance at this time. REPOSITORY R175

D28874: Taiwanese holidays

ngraham added a comment. Do you not have commit access? I thought you were the maintainer based on the repo's history! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: ngraham, winterz, kde-frameworks-devel, LeGast00n,

D28874: Taiwanese holidays

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks good. all tests pass. could someone commit this for us? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz

D28874: Taiwanese holidays

shrapnel updated this revision to Diff 80415. shrapnel added a comment. Removed patch-file REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80346=80415 REVISION DETAIL https://phabricator.kde.org/D28874 AFFECTED FILES holidays/holidays.qrc

D28874: Taiwanese holidays

winterz added a comment. remove holidays/0001-added-holiday_tw_zh-and-updated-holiday.qrc.patch REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

shrapnel updated this revision to Diff 80346. shrapnel added a comment. Uploaded .diff instead of .patch REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80303=80346 REVISION DETAIL https://phabricator.kde.org/D28874 AFFECTED FILES

D28874: Taiwanese holidays

Zren added a comment. Phab only understands `.diff`. Phab does not recognize `.patch`. git diff --staged > D28874.diff Or: git diff origin/master > D28874.diff REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren,

D28874: Taiwanese holidays

shrapnel updated this revision to Diff 80303. shrapnel added a comment. Fixed the typos REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80288=80303 REVISION DETAIL https://phabricator.kde.org/D28874 AFFECTED FILES

D28874: Taiwanese holidays

Zren added a comment. There's a few extra spaces at the end of `"植樹節 "` and `"中秋節 補假 "` too. Not sure how well you know `git`, but make sure to run `git add holidays/plan2/holiday_tw_zh` again after making your changes, before running `git diff --staged` to upload the modified diff.

D28874: Taiwanese holidays

winterz added a comment. problems: - "religous" should be "religious" - missing ':' at the start of Constitution Day - missing ':' at the start of Christmas Day REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc:

D28874: Taiwanese holidays

winterz requested changes to this revision. winterz added a comment. This revision now requires changes to proceed. testing fails. don't know why yet. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: winterz,

D28874: Taiwanese holidays

shrapnel updated this revision to Diff 80288. shrapnel added a comment. Hopefully the changes to both files are there now REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80277=80288 REVISION DETAIL https://phabricator.kde.org/D28874 AFFECTED

D28874: Taiwanese holidays

Zren added a comment. Now you're missing `holidays/plan2/holiday_tw_zh` which can still be seen here: https://phabricator.kde.org/D28874?id=80260 git add holidays/holidays.qrc git add holidays/plan2/holiday_tw_zh git diff --staged > D28874.diff REPOSITORY R175 KHolidays

D28874: Taiwanese holidays

shrapnel updated this revision to Diff 80277. shrapnel edited the summary of this revision. shrapnel added a comment. Added holiday_tw_zh to holidays.qrc-file (I'm new to git/phabricator so hopefully it makes sense) REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D28874: Taiwanese holidays

winterz added a comment. you need to add the change to holidays.qrc to this patch REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

shrapnel edited the summary of this revision. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

shrapnel created this revision. shrapnel added reviewers: VDG, Zren. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shrapnel requested review of this revision. REVISION SUMMARY File containing taiwanese holidays REPOSITORY R175 KHolidays REVISION DETAIL