D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. @blaze, (I couldn't find your user name at invent.kde.org); FYI: https://invent.kde.org/network/falkon/-/merge_requests/7 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, blaze Cc: kde-frameworks

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#651415 , @dfaure wrote: > In D28880#651209 , @ahmadsamir wrote: > > > There are only two places in KDE code where readEntryList() is used, falkon and kwalletman

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. In D28880#651209 , @ahmadsamir wrote: > There are only two places in KDE code where readEntryList() is used, falkon and kwalletmanager; in both cases readEntryList() was used with "*" which means "read all entries", whic

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. There are only two places in KDE code where readEntryList() is used, falkon and kwalletmanager; in both cases readEntryList() was used with "*" which means "read all entries", which is logical since in both cases the list is used to fill a "password manager" of so

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. Fair point. For searches made by users, that's arguable, but indeed here if it's a search made by C++ code, then we could very well have a readEntryList(QRegularExpression) overload for that use case [or a method with another name, especially if DBus is involved].

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#651001 , @dfaure wrote: > A Qt change request for something like QRegularExpression::wildcardToRegularExpression(str, QRegularExpression::AllowSlashes) Ah, I see; could be useful, yes. (Personal

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. A Qt change request for something like QRegularExpression::wildcardToRegularExpression(str, QRegularExpression::AllowSlashes) REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, blaze Cc: kde-frameworks

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R311:5bbe2a77a7af: [KWallet] Port last usage of QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28880?vs=80270&id=

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#650985 , @dfaure wrote: > This keeps happening so I wonder if we need a QRegularExpression::wildcardToRegularExpression flag... What do you mean by flag? REPOSITORY R311 KWallet BRANCH l-wildcar

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This keeps happening so I wonder if we need a QRegularExpression::wildcardToRegularExpression flag... REPOSITORY R311 KWallet BRANCH l-wildcard (branched from master) REVISION DETAIL

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#650974 , @dfaure wrote: > And what's the value of `key`? I wonder where/how the use of globbing/regexps comes in... Backend::readEntryList() docs say it supports wildcards, so "key" could be "foo*" t

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. And what's the value of `key`? I wonder where/how the use of globbing/regexps comes in... REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, blaze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#650963 , @dfaure wrote: > Annoying feature of QRegularExpression :( They're being "technically" correct; I have to say using "*" to match foo/bar.txt is wrong, it should be */* if we're talking about

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

dfaure added a comment. Annoying feature of QRegularExpression :( *.txt doesn't seem like a good example for wallet search.. any idea how this code is typically used? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, bla

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, blaze. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY QRegularExpression::wildcardToRegularExpression() mainly handles file pattern globbing (e.g. "*.txt") whic