D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, nicolasfella. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use new KBookMarkMenu ctor that doesn't take a KActionCollection parameter; AFAICS there's no need

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir added a comment. Though maybe I should add a comment about the action collection, if the kfiledialog ever grows a shortcuts editor dialog, those actions will be missing, and tracking down the issue mightn't be that easy... REPOSITORY R241 KIO REVISION DETAIL https://phabricat

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. Well, all of KF5 is supposed to always be the same version. You don't need the ifdef for old kbookmarks version. KIO 5.70 requires KBookmarks 5.70. REPOSITORY R241 KIO BRANC

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir added a comment. In D28910#650745 , @dfaure wrote: > Thanks. > > Well, all of KF5 is supposed to always be the same version. You don't need the ifdef for old kbookmarks version. KIO 5.70 requires KBookmarks 5.70. Ah, yes, m

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir updated this revision to Diff 80440. ahmadsamir added a comment. Remove ifdef, all KF5 parts require the same version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28910?vs=80364&id=80440 BRANCH l-kbookmark (branched from master) REVISION DETAIL

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bd7607f43dea: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69 (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28910?vs=80440&id=80441 RE