D29051: Add ecm_generate_dbus_service_file

2020-05-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. A unit test would be good to have. The test for ECMGeneratePkgConfigFile might be a sample for this. INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:17 > +# > +# A D-Bus service file ``.service` will will be generated and > installed > +# in the relevant D-Bus c

D29051: Add ecm_generate_dbus_service_file

2020-05-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 83105. broulik added a comment. - Clarify docs REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29051?vs=80776&id=83105 REVISION DETAIL https://phabricator.kde.org/D29051 AFFECTED FILES docs/module/ECMGe

D29051: Add ecm_generate_dbus_service_file

2020-05-22 Thread Kai Uwe Broulik
broulik marked 3 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, br

D29051: Add ecm_generate_dbus_service_file

2020-04-23 Thread Friedrich W. H. Kossebau
kossebau added a comment. Any chance for a simple unit test to check the generation does what is expected (or catches bad input)? :) INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:22 > +# are to be installed in the same directory as the D-Bus daemon. On other > platforms > +# must

D29051: Add ecm_generate_dbus_service_file

2020-04-23 Thread David Edmundson
davidedmundson added a dependent revision: D28305: Systemd Startup. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencrea

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik updated this revision to Diff 80776. broulik added a comment. Add docs rst REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29051?vs=80775&id=80776 REVISION DETAIL https://phabricator.kde.org/D29051 AFFECTED FILES docs/module/ECMGene

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik updated this revision to Diff 80775. broulik added a comment. - Improve docs - Add `DESTINATION` arg REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29051?vs=80766&id=80775 REVISION DETAIL https://phabricator.kde.org/D29051 AFFECTED

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Friedrich W. H. Kossebau
kossebau added a comment. Some first quick comments, not yet looked at code itself. Misses also link file from doc/. INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:6 > +# This module provides the ``ecm_generate_dbus_service_file`` function for > +# generating a D-Bus service file. >

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, L

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngrah

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, kossebau, kfunk, habacker. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It serves a