D29083: correct vscode icon name

2020-04-21 Thread Yunhe Guo
guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29083 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29083: correct vscode icon name

2020-04-21 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY `com.visualstudio.code.svg` and `com.visualstudio.code.oss.svg` REPOSITORY R266 Breeze Icons BRANCH master REVI

D29083: correct vscode icon name

2020-04-22 Thread Nathaniel Graham
ngraham added reviewers: cblack, VDG, ndavis. ngraham added a comment. Could the old one still ever be valid ? Should we maybe add a symlink instead of renaming? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29083 To: guoyunhe, #breeze, cblack, #vdg, ndavis C

D29083: correct vscode icon name

2020-04-22 Thread Yunhe Guo
guoyunhe added a comment. The icon was renamed since 2018. Most users should have updated to newer version. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29083 To: guoyunhe, #breeze, cblack, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, m

D29083: correct vscode icon name

2020-04-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I suppose anyone using an old version would be on a discrete release distro that wouldn't update breeze icons either. OK, ship it! REPOSITORY R266 Breeze Icons BRANCH master REVISIO

D29083: correct vscode icon name

2020-04-22 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R266:d44aa218457b: correct vscode icon name (authored by Guo Yunhe ). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29083?vs=80838&id=80916#toc REPOSITORY R266 Breeze Icons CH