This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:1d8d223745eb: Use UI marker context in more tr() calls
(authored by kossebau).
REPOSITORY
R294 KBookmarks
CHANGES
aacid added a comment.
+0.5
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D29369
To: kossebau, #frameworks, #localization
Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
kossebau added inline comments.
INLINE COMMENTS
> aacid wrote in kbookmarkmenu.cpp:288
> @title:inmenu?
Nope, this is a normal action/menu entry, the variable name is misleading here
a bit. See below e.g. for the slot added.
REPOSITORY
R294 KBookmarks
REVISION DETAIL
aacid added inline comments.
INLINE COMMENTS
> kbookmarkmenu.cpp:288
>
> -QString title = tr("Open Folder in Tabs");
> +const QString title = tr("Open Folder in Tabs", "@action:inmenu");
>
@title:inmenu?
REPOSITORY
R294 KBookmarks
REVISION DETAIL
kossebau created this revision.
kossebau added reviewers: Frameworks, Localization.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Also fix lowercase "toolbar" in action text to Title
