D29372: Taiwan: Use "zh_TW" language code

weisi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. weisi requested review of this revision. REVISION SUMMARY It was set to `tw_zh` which I think is a typo. According to Wikipedia, > `zh-TW` is the IETF language tag for the Chine

D29372: Taiwan: Use "zh_TW" language code

weisi added a reviewer: winterz. weisi added a comment. Adding a reviewer to this diff. Thanks! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29372: Taiwan: Use "zh_TW" language code

cgiboudeaux added a comment. D29223 addresses the issue and needs review REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bru

D29372: Taiwan: Use "zh_TW" language code

nhiga added a comment. I would say that the file should also be renamed. //My comment from D29223 :// > The new file name follows the same naming scheme used by the PRC (mainland China) holiday file, holiday_cn_zh-cn (holiday_region_Language-Region

D29372: Taiwan: Use "zh_TW" language code

weisi added a comment. I think the approach in D29223 (renaming the file also) is more preferred. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: nhiga, cgiboudeaux, kde-frameworks-devel, LeGast00n,

D29372: Taiwan: Use "zh_TW" language code

weisi abandoned this revision. weisi added a comment. Closing this revision. Let's get D29223 in. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: nhiga, cgiboudeaux, kde-frameworks-devel, LeGast00n,