D29503: Pixel align children of GridViewInternal

2020-05-07 Thread Fabian Vogt
fvogt added a comment. In D29503#665612 , @ngraham wrote: > I can't reproduce it, but I wonder if this could fix or help https://bugs.kde.org/show_bug.cgi?id=417488? Yup, that's exactly what I was seeing before this change: F8293538: 8sM

D29503: Pixel align children of GridViewInternal

2020-05-07 Thread Nathaniel Graham
ngraham added a comment. I can't reproduce it, but I wonder if this could fix or help https://bugs.kde.org/show_bug.cgi?id=417488? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29503 To: fvogt, #frameworks, broulik, mart, davidedmundson Cc: ngraham, kde-frame

D29503: Pixel align children of GridViewInternal

2020-05-07 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R296:9725a21bcd0e: Pixel align children of GridViewInternal (authored by fvogt). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29503?vs=82183&id=82184 REVISION DE

D29503: Pixel align children of GridViewInternal

2020-05-07 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D29503 To: fvogt, #frameworks, broulik, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29503: Pixel align children of GridViewInternal

2020-05-07 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D29503 To: fvogt, #frameworks, broulik, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh

D29503: Pixel align children of GridViewInternal

2020-05-07 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Frameworks, broulik, mart. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY The scroll bar size can be odd (for breeze it's 21), which causes leftMargin to be 12.5. This causes every delegate insid