D29534: Implement scroll and drag adjustment of values for SpinBox control

ngraham closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma, ahiemstra Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

ahiemstra accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH implement-spinbox-wheel-adjustment (branched from master) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma, ahiemstra Cc: ahiem

D29534: Implement scroll and drag adjustment of values for SpinBox control

ngraham added a comment. @ahiemstra #frameworks #plasma ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: ahiemstra, a

D29534: Implement scroll and drag adjustment of values for SpinBox control

ngraham updated this revision to Diff 82786. ngraham marked an inline comment as done. ngraham added a comment. Address review comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29534?vs=82311&id=82786 BRANCH implement-spinbox-whee

D29534: Implement scroll and drag adjustment of values for SpinBox control

ahiemstra added inline comments. INLINE COMMENTS > SpinBox.qml:54 > +// Because we're stomping the Text Input's own mouse handling > +textField.forceActiveFocus() > +} You can do `mouse.accepted = false` instead of forceActiveFocus to allow the mouse

D29534: Implement scroll and drag adjustment of values for SpinBox control

abetts added a comment. +1 from me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

ngraham added a comment. In D29534#666554 , @ndavis wrote: > I don't like the look of those +/- buttons. I think this makes it harder to know that you can drag the panel height up and down. That would be a comment for D29535

D29534: Implement scroll and drag adjustment of values for SpinBox control

ndavis added a comment. I don't like the look of those +/- buttons. I think this makes it harder to know that you can drag the height up and down. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: ndavis, cblack,

D29534: Implement scroll and drag adjustment of values for SpinBox control

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

ngraham retitled this revision from "Implement wheel/touchpad scrolling for SpinBox control" to "Implement scroll and drag adjustment of values for SpinBox control". ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.k