D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz created this revision. winterz added a reviewer: vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. winterz requested review of this revision. REVISION SUMMARY The German holiday files now all have a proper country and name since commits 4bdc6

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz added a comment. I'm guessing it's ok to depend on K5I18N ? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29575 To: winterz, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

ltoscano added a comment. In D29575#667175 , @winterz wrote: > I'm guessing it's ok to depend on K5I18N ? KHolidays is a Tier 1 framework, so it can't depend on KI18n. Just use QCoreApplication::translate as used already in src/holidayreg

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz updated this revision to Diff 82398. winterz added a comment. don't try to provide translatable string for unknown subdivisions REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575?vs=82396&id=82398 BRANCH master REVISION DETAIL https://phab

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz updated this revision to Diff 82442. winterz added a comment. QLatin1-ify REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575?vs=82398&id=82442 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29575 AFFECTED FILES src/holidayre

D29575: holidayregion.cpp - provide translatable strings for the German regions.

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH master REVISION DETAIL https://phabricator.kde.org/D29575 To: winterz, vkrause Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

This revision was automatically updated to reflect the committed changes. Closed by commit R175:7f7533260efc: holidayregion.cpp - provide translatable strings for the German regions. (authored by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575