dhaumann added a comment.
Restricted Application added a project: Kate.
Restricted Application edited subscribers, added: kde-frameworks-devel,
kwrite-devel; removed: Frameworks.
Could you provide a test snippet now? I will integrate this then.
REPOSITORY
R216 Syntax Highlighting
REVISION
arichardson updated this revision to Diff 30212.
arichardson marked 2 inline comments as done.
arichardson added a comment.
address comments
will try to add tests soon
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4716?vs=11618&id=30212
BRAN
dhaumann added a comment.
@arichardson friendly ping :-) In case you don't have the time, it's also OK
to paste some example code in a comment here (MIT licensed, please). Then, we
can proceed.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D4716
To: ar
arichardson added a comment.
Sorry, was busy with other stuff so completely forgot about this. I'll update
this soon.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D4716
To: arichardson, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, hase, mi
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
ping?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D4716
To: arichardson, dhaumann, vkrause
Cc: #frameworks
dhaumann added a comment.
I think in general a good idea.
Some comments:
- Could you update the patch with the mentioned issues?
- Could you also provide two test cases (under MIT license) that demonstrate
MIPS and GNU Assembler highlighting? That would be very helpful for our unit
arichardson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Add a few 64-bit MIPS instruction mnemonics
Add c-preprocessor.xml highlighting file to be included
Extracted and slightly modi
