D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:23b70f4d4524: Implement FadingMaterial frag/vert shaders on core profile (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4851?vs=11986&id=12207#toc REPOSITORY R2

D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR242 Plasma Framework (Library)BRANCHmasterREVISION DETAILhttps://phabricator.kde.org/D4851EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: davidedmundson, Plasma, mar

[Differential] [Commented On] D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-01 Thread Marco Martin
mart added a comment. sorry for the noise, it was a local setup problem, it works correctly now +1 from me REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4851 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-01 Thread Marco Martin
mart added a comment. also, Failed to find shader ":/plasma-framework/shaders/fadingmaterial_core.vert" Failed to find shader ":/plasma-framework/shaders/fadingmaterial_core.frag" QOpenGLShader:🔗 Vertex shader(s) failed to link, fragment shader(s) failed to link. Vertex link error: INV

[Differential] [Commented On] D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-01 Thread Marco Martin
mart added a comment. tried it now on ati proprietary, the icon does have the highlight effect at the end of the animation but disappear during the animation. on terminal i have the following error: shader compilation failed: "Vertex shader(s) failed to link, fragment shader(s) faile

[Differential] [Updated] D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-01 Thread David Edmundson
davidedmundson added a dependency: D4848: Split frag and vert code of FadingNode into separate files. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4851 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmun

[Differential] [Request, 22 lines] D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-02-28 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Like all the inbuilt shaders this now has a separate GLS source file which works with a newer version without re