D5089: KDE compiler settings fail to consider AppleClang

2017-03-19 Thread René J . V . Bertin
rjvbb closed this revision. rjvbb added a comment. https://commits.kde.org/extra-cmake-modules/7af9f8e2b6eb235923a329e8ff24012883fb6b86 REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks, kfunk Cc: kfunk, apol, kde-mac, #frameworks, #build_system

D5089: KDE compiler settings fail to consider AppleClang

2017-03-18 Thread Kevin Funk
kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. LGTM REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks, kfunk Cc: kfunk, apol, kde-mac, #frameworks, #build_system

D5089: KDE compiler settings fail to consider AppleClang

2017-03-18 Thread René J . V . Bertin
rjvbb updated this revision to Diff 12583. rjvbb added a comment. Uses `MATCHES "Clang"` . Tested and appears to work with AppleClang `Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)` CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5089?vs=12572&id=12583 REVISION

D5089: KDE compiler settings fail to consider AppleClang

2017-03-17 Thread Kevin Funk
kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks, kfunk Cc: kfunk, apol, kde-mac, #frameworks, #build_system

D5089: KDE compiler settings fail to consider AppleClang

2017-03-17 Thread Kevin Funk
kfunk added a comment. +1 to apol's recommendation. `... MATCHES "Clang"` is the expression everyone uses. Even in cmake.git: Modules/CMakeDetermineCCompiler.cmake 138: if(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES "Clang") Also see: http://stackov

D5089: KDE compiler settings fail to consider AppleClang

2017-03-17 Thread René J . V . Bertin
rjvbb added a comment. In https://phabricator.kde.org/D5089#95732, @apol wrote: > Maybe it would make sense to use MATCHES? are there any other *Clang*? That was my first idea, use `MATCHES "*Clang"`, but then I realised I have no idea if there are other SomethingClang. Searching

D5089: KDE compiler settings fail to consider AppleClang

2017-03-17 Thread Aleix Pol Gonzalez
apol added a comment. Maybe it would make sense to use MATCHES? are there any other *Clang*? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks Cc: apol, kde-mac, #frameworks, #build_system

D5089: KDE compiler settings fail to consider AppleClang

2017-03-17 Thread René J . V . Bertin
rjvbb created this revision. rjvbb added projects: Build System, Frameworks. REVISION SUMMARY KDECompilerSettings.cmake and KDEFrameworksCompilerSettings.cmake fail to consider the fact that cmake considers Apple's clang compiler to be different (differences that exist but are largely irreleva