D5167: Move .po and .ts files look-up to build-time

This revision was automatically updated to reflect the committed changes. Closed by commit R249:a54ae95b520e: Move .po and .ts files look-up to build-time (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5167?vs=13404=13654#toc REPOSITORY R249 KI18n CHANGES SINCE

D5167: Move .po and .ts files look-up to build-time

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Note that there's still an ordering problem with the new fetch-translations target now. The {ts,po}files-* targets can run before the fetch-translations target so on first run you may have

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 13404. apol added a comment. AUTHOR_WARNING REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=13392=13404 BRANCH fetchbuildtime REVISION DETAIL https://phabricator.kde.org/D5167 AFFECTED FILES CMakeLists.txt

D5167: Move .po and .ts files look-up to build-time

sitter added inline comments. INLINE COMMENTS > KF5I18NMacros.cmake:136 > +function(ki18n_install_ts_files _lang) > +message(WARNING "KI18N_INSTALL_TS_FILES is deprecated!") > +ki18n_install(${_lang}) Please use `message(AUTHOR_WARNING ...` this warning has only relevance to a

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 13392. apol marked 2 inline comments as done. apol added a comment. Address some issues pointed at by sitter REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=13118=13392 BRANCH fetchbuildtime REVISION DETAIL

D5167: Move .po and .ts files look-up to build-time

sitter added a comment. The code currently isn't working for po/ in source dir and you are losing a public function. See inline comments. (Why there are no autotests for a complicated, involved, and important function like ki18n_install is entirely beyond my appreciation. How in the

D5167: Move .po and .ts files look-up to build-time

apol added a comment. @ltoscano ping? (you asked me for this... ) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5167 To: apol, #frameworks, sitter, ltoscano, ilic Cc: aacid

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 13118. apol added a comment. Makes it possible to have ${CMAKE_SOURCE_DIR} and ${CMAKE_BINARY_DIR} REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=12987=13118 BRANCH fetchbuildtime REVISION DETAIL

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 12987. apol added a comment. Remove unneeded changes REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=12931=12987 BRANCH fetchbuildtime REVISION DETAIL https://phabricator.kde.org/D5167 AFFECTED FILES

D5167: Move .po and .ts files look-up to build-time

apol added a comment. Now it seems to work properly with scripts: $ LANGUAGE=pl kgeography KTranscript: Loaded property map: /home/apol/devel/kde5/share/locale/pl/LC_SCRIPTS/kgeography/general.pmapc KTranscript: Loaded module:

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 12931. apol added a comment. Fix REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=12930=12931 BRANCH fetchbuildtime REVISION DETAIL https://phabricator.kde.org/D5167 AFFECTED FILES CMakeLists.txt

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 12930. apol added a comment. Fix several issues Properly test projects with ts and pmap files Make sure we install the files in the correct place Make sure we don't fail if the project calls KI18N_INSTALL twice REPOSITORY R249 KI18n CHANGES SINCE

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 12867. apol added a comment. Install in the correct directory REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=12862=12867 BRANCH fetchbuildtime REVISION DETAIL https://phabricator.kde.org/D5167 AFFECTED FILES

D5167: Move .po and .ts files look-up to build-time

apol added a comment. This is KAlgebra in catalan with the translations generated with this method: F3317742: Spectacle.jU4256.png If I use `LANGUAGE=sr` it doesn't work, I don't know why though, it doesn't error but it's likely I'm messing up

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 12862. apol added a comment. Uncomment test, remove unneeded glob REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=12772=12862 BRANCH fetchbuildtime REVISION DETAIL https://phabricator.kde.org/D5167 AFFECTED

D5167: Move .po and .ts files look-up to build-time

aacid added a comment. s/Tried/try REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5167 To: apol, #frameworks, sitter, ltoscano, ilic Cc: aacid

D5167: Move .po and .ts files look-up to build-time

aacid added a comment. Tried it in kde-l10n-sr for example REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5167 To: apol, #frameworks, sitter, ltoscano, ilic Cc: aacid

D5167: Move .po and .ts files look-up to build-time

aacid added a comment. Have you tried this? That commented out test doesn't seem like a good idea. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5167 To: apol, #frameworks, sitter, ltoscano, ilic Cc: aacid

D5167: Move .po and .ts files look-up to build-time

apol added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5167 To: apol, #frameworks, sitter, ltoscano, ilic

D5167: Move .po and .ts files look-up to build-time

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY As specified in cmake's documentation, file(GLOB) is not recommended for looking up sources because it requires cmake to be regenerated to be able to process what needs to be executed. This