D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb added a comment. In https://phabricator.kde.org/D5178#99143, @bcooksley wrote: > We won't be modifying Phabricator, in part because Arcanist as shipped by upstream is designed to work with that text. We're talking about the trigger in commit messages made with regular git c

D5178: QtCurve/Qt5 : further KF5 adaptation

bcooksley added a comment. We won't be modifying Phabricator, in part because Arcanist as shipped by upstream is designed to work with that text. Modifying it will create maintenance burden in the long run and lead to incompatibility with the software which runs on developers systems - requ

D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb added a comment. In https://phabricator.kde.org/D5178#99097, @ltoscano wrote: > > Differential Revision: https://phabricator.kde.org/D5178 I suppose it would technically be possible to support `REVIEW:` instead of `Differential Revision:` on a commit's last line o

D5178: QtCurve/Qt5 : further KF5 adaptation

ltoscano set the repository for this revision to R626 QtCurve. REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D5178 To: rjvbb, yuyichao Cc: ltoscano, #frameworks, yuyichao

D5178: QtCurve/Qt5 : further KF5 adaptation

ltoscano added a comment. In order to properly close the review, please either use arcanist (suggested method) or the last line should have been: Differential Revision: https://phabricator.kde.org/D5178 REVISION DETAIL https://phabricator.kde.org/D5178 To: rjvbb, yuyichao Cc: ltoscano, #

D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb closed this revision. rjvbb added a comment. https://commits.kde.org/qtcurve/820a35e02cc6c31a4db9dccf40a83ba7a771dd03 REVISION DETAIL https://phabricator.kde.org/D5178 To: rjvbb, yuyichao Cc: #frameworks, yuyichao

D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb added a comment. In https://phabricator.kde.org/D5178#99057, @yuyichao wrote: > Is this the new review platform? Yep. > LGTM. Hopefully I'm doing the right action here (phabricator always seem to have way more buttons than I need..) I think so. Phab is indeed c

D5178: QtCurve/Qt5 : further KF5 adaptation

yuyichao accepted this revision. yuyichao added a comment. This revision is now accepted and ready to land. Is this the new review platform? LGTM. Hopefully I'm doing the right action here (phabricator always seem to have way more buttons than I need..) REVISION DETAIL https://phab

D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb added a comment. KWin5 context menus with an item selected, with my regular light desktop theme and the Breeze Dark palette (with and without the patch). QtCurve is configured to render the menu backdrop with a 100% HSV-based shade lightening (the main reason why KWin's context men

D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb added a comment. KWin5 context menu when (only) the application uses the Breeze Dark palette, with and without the current patch. F3241430: qtcurve-winmenu-brdark-unreadable.png F3241429: qtcurve-winmenu-brdark.png

D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb added a comment. Menu appearance with my regular light desktop palette and when only the application (oxygen-demo5) was switched to the Breeze Dark palette. F3241388: qtcurve-winmenu.png F3241387: qtcurve-menu.png

D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb updated this revision to Diff 12817. rjvbb added a comment. this version attempts to take a few settings into account for rendering the items in the special-case KWin context menus. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5178?vs=12799&id=12817 REVISION DETAIL https:

D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb created this revision. REVISION SUMMARY This patch introduces several improvements to QtCurve's integration with KF5: - Inherit KStyle instead of QCommonStyle when built with KDE support - recognise at least KF5 systemsettings application and above all KWin5 - use the new method o