This revision was automatically updated to reflect the committed changes.
Closed by commit R306:c86a0f9f7de9: API dox: fix missing note to call
setXMLFile with KParts::MainWindow (authored by kossebau).
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
kossebau added a comment.
> Also note that lxr finds all calls to setXMLFile, including those in parts
and plugins, while here we're only talking about kparts mainwindows.
Eh, I had made the extra effort to first do string search for
"KParts::MainWindow", then manually grep in linked
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I agree.
The person who wrote this API doc was aiming for something slightly simpler
(one less method to call), but my original design was for everyone to call
setXMLFile, and it would
kossebau added a comment.
In https://phabricator.kde.org/D5181#97662, @dfaure wrote:
> Not sure which solution is better.
Considered that alternative as well, but then chose to propose the given
patch for these reasons:
- code supporting KF <5.34 would still need some
dfaure added a comment.
Seems right. The alternative is to make it work.
Not sure which solution is better.
- kxmlgui/src/kxmlguiwindow.cpp
+++ kxmlgui/src/kxmlguiwindow.cpp
@@ -203,6 +203,8 @@ void KXmlGuiWindow::setupGUI(const QSize ,
StandardWindowOptions opt
if
kossebau edited the summary of this revision.
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D5181
To: kossebau, dfaure, elvisangelaccio, #frameworks
kossebau edited reviewers, added: Frameworks; removed: KDevelop.
kossebau removed a subscriber: Frameworks.
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D5181
To: kossebau, dfaure, elvisangelaccio, #frameworks
kossebau created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Calling KXmlGuiWindow::setupGUI(flags, xmlfile) without the "Create"
flag will result in the xmlfile argument being ignored.
So
