D5185: prevent signals in glib2 be defined by QT

2017-03-26 Thread Robert Lu
RobberPhex created this revision. RobberPhex added a project: Frameworks. REVISION SUMMARY Because signals in glib2 be defined by QT, cause Bug 378109 - signals in glib2 was defined by QT . This solved this. TEST PLAN Use nm_conn.cpp

D5185: prevent signals in glib2 be defined by QT

2017-03-26 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah, networkmanager-qt itself uses KDEFrameworkCompilerSettings so it gets -DQT_NO_SIGNALS_SLOTS_KEYWORDS, i.e. signals isn't defined. But indeed this is an installed public header, so the

D5185: prevent signals in glib2 be defined by QT

2017-03-27 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R282:b08b9c425fb0: prevent signals in glib2 be defined by Qt (authored by RobberPhex, committed by aacid). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5185?v