D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-21 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R236:8a1c758516fd: KPasswordDialog: don't hide visibility action in plaintext mode (authored by elvisangelaccio). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-21 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ok, I just wanted to be sure :) REPOSITORY R236 KWidgetsAddons BRANCH kpassworddialog-leak REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, fvogt, cfeck Cc: #frameworks

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-20 Thread Christoph Feck
cfeck added a comment. Elvis, this was already accepted. If I had objections, I would have stopped you :) REPOSITORY R236 KWidgetsAddons BRANCH kpassworddialog-leak REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, fvogt, cfeck Cc: #frameworks

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-20 Thread Elvis Angelaccio
elvisangelaccio added a comment. @cfeck Ping? REPOSITORY R236 KWidgetsAddons BRANCH kpassworddialog-leak REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, fvogt, cfeck Cc: #frameworks

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-06 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D5312#100027, @fvogt wrote: > Tested locally, works fine! > > The behaviour is a bit unexpected, but IMO correct: > > - Enter a password > - Make it visible > - Delete it > - Toggle visibility -> VisibilityAction

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-06 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested locally, works fine! The behaviour is a bit unexpected, but IMO correct: - Enter a password - Make it visible - Delete it - Toggle visibility -> VisibilityAction sta

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-05 Thread Elvis Angelaccio
elvisangelaccio added a dependent revision: D5313: Add workaround for bug in QLineEdit's clear button. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, cfeck, fvogt Cc: #frameworks

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-05 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Otherwise the user cannot tell whether what's going to be typed will be visible or not. BUG: 378276 FIXED-IN: 5.34 REPOSITO