This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ca846fbda318: Rebased Less syntax highlighting on SCSS
one (authored by gszymaszek).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5799?vs=18296=18391
dhaumann accepted this revision.
dhaumann added a comment.
Looks good to me, I think we should include this change.
@gszymaszek Shall I commit this, or do you have commit rights? If you don't
have commit rights, you should consider getting a KDE commit account.
REPOSITORY
R216 Syntax
gszymaszek updated this revision to Diff 18296.
gszymaszek added a comment.
Removed leading and trailing spaces inside XML tags (in `less.xml`), to make
it possible to build the framework.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
jtamate requested changes to this revision.
jtamate added a comment.
This revision now requires changes to proceed.
Hello,
To be able to compile with the current frameworks, I have had to remove the
leading/trailing spaces:
gszymaszek updated this revision to Diff 15814.
gszymaszek added a comment.
Added a test file (`autotests/input/highlight.less`).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5799?vs=14376=15814
REVISION DETAIL
dhaumann added a comment.
@gszymaszek Could you also add a unit test to autotest/input/highlight.less ?
This way, we can guarantee to not break the highlighting with future changes,
which is very hard otherwise. The reference data is created by calling
autotest/update-reference-data.sh in
