This revision was automatically updated to reflect the committed changes.
Closed by commit R313:07a8a4e6985c: Pass `--key-positions=*` to gperf instead
of `-k *` because on Windows this… (authored by arrowdodger).
REPOSITORY
R313 KHtml
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5
arrowdodger added a comment.
In https://phabricator.kde.org/D5890#110586, @bcooksley wrote:
> This looks good to me. Would this also resolve
https://build-sandbox.kde.org/view/Frameworks/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsQt5.7/6/console
?
> Invalid position value
bcooksley accepted this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
This looks good to me. Would this also resolve
https://build-sandbox.kde.org/view/Frameworks/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsQt5.7/6/console
?
REPOSITORY
R313 KHtml
BR
arrowdodger created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this
symbol seems to have a special meaning.
TEST PLAN
Successfully compiled with MSVC.
REPOSITORY
R313 KHtml
BRA
