tcberner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I don't think it makes sense, that the icons are xmllint'ed every time
someone builds the icons.
This is an action that should take plac
tcberner added a reviewer: winterz.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D6076
To: tcberner, #freebsd, winterz
Cc: #frameworks
tcberner updated this revision to Diff 15115.
tcberner added a comment.
- Fix cmake
- find_program call for xmllint
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6076?vs=15114&id=15115
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/
tcberner updated this revision to Diff 15116.
tcberner added a comment.
Add find_programm(SH_EXE sh)
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6076?vs=15115&id=15116
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6076
AFFECTED F
rakuco added a comment.
See also: https://git.reviewboard.kde.org/r/129246/
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D6076
To: tcberner, #freebsd, winterz
Cc: rakuco, #frameworks
aacid added a comment.
i think it'd be much more acceptable if you made it equal to be "running
tests" like we have on other repos, so on by default but when running make
check.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D6076
To: tcberner, #freebsd, winte
adridg commandeered this revision.
adridg added a reviewer: tcberner.
adridg added a comment.
Taking over to follow up Albert's suggestion -- this could be two patches,
one to de-bash it, one to make validation optional.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kd
adridg updated this revision to Diff 15820.
adridg added a comment.
Make the diff smaller: only de-bash it, and save make-validation-optional
for a later patch.
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6076?vs=15116&id=15820
BRANCH
arcpatch-
aacid added a comment.
I don't think i know enough sh to give it a "this is compatible with basic
sh", but i guess that if it works you can commit it.
Only thing is that maybe you don't really need to de-bash optimize-svg.sh and
icons-dark/light2Dark since they seem things you run manual
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c6a290a2e154: Do not depend on bash uncessarily, and do
not validate icons by default. (authored by tcberner, committed by adridg).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6076?vs=15820&
10 matches
Mail list logo
