leinir created this revision.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Engine has a pageSize variable which has been mostly unused, but which comes
in very handy when getting la
apol added a comment.
I have no idea about the patch itself, why it wasn't exposed so far that is.
INLINE COMMENTS
> engine.cpp:144
> + */
> +void setPageSize(const int& pageSize);
> Q_SIGNALS:
I wouldn't pass an int as `const&`
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https:
leinir added a comment.
As far as i can gather, it was simply never added because, well, it was never
used in a lot of places... This really is more a case of equalising some
features between requestData and other parts of the engine (so they can all be
paginated by the size they really want
leinir updated this revision to Diff 15377.
leinir added a comment.
Don't const & an int, that's just silly.
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6190?vs=15373&id=15377
REVISION DETAIL
https://phabricator.kde.org/D6190
AFFECTED FILES
src/c
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
It all makes sense, so good from my side.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6190
To: leinir, #knewstuff, apol
Cc: apol, #frameworks, ZrenBot
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:2f8580b9e604: Expose and use Engine's page size variable
(authored by leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6190?vs=15377&id=15443#toc
REPOSITORY
R304 KNewStuff
CHANGES SI
