mart updated this revision to Diff 15462.
mart added a comment.
update size in showevent
update size in showevent, get rid of aboutToShow signal
showing and hiding mainItem (as opposed to its window)
had repercussions on the size calculation, giving it
a stuttering appearance when wi
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in dialog.cpp:1368-1370
> You can't move the code from updateVisibility as we need it to work with an
> upcasted QQuickWindow::setVisible .
> That's probably the main reason you ended up having to change the pointer
> type in t
mart updated this revision to Diff 15446.
mart added a comment.
don't update the size twice
only update the size in setvisible, not in updatevisibility.
if this is done in the showEvent instead, it's too late and
is possible to see a resize on screen
REPOSITORY
R242 Plasma Framew
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in dialog.cpp:1368-1370
> >> this is already done in updateVisibility which is effectively called from
> >
> > i think it should be safe to remove it from updatevisibility
>
> hmm, actually not, seems sometimes it needs to be
sebas added a comment.
I like this, and I'll likely need it in my kscreen OSD code aswell
(positioning there is unreliable, and my best guess is that this is the exact
same problem @mart is trying to solve here).
+1
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https:/
mart added inline comments.
INLINE COMMENTS
> mart wrote in dialog.cpp:1368-1370
> > You've not really said what problem we're trying to solve with this patch.
>
> having a pointt in which we are 100% sure of the final size of the dialog to
> correctly position it.
> if visualparent is set, thi
hein added a comment.
I used to subclass in Simple Menu, but then eliminated the C++ plugin so I
could put it on the Store, so this is important for now.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6215
To: mart, #plasma, davidedmundson
Cc: he
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in dialog.cpp:1368-1370
> this is already done in updateVisibility which is effectively called from
>
> QQuickWindow::setVisible(visible);
>
> So we're just doing things twice.
>
> You've not really said what problem we're try
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dialog.cpp:1368-1370
> +if (d->mainItem) {
> +d->mainItem->setVisible(true);
> +d->syncToMainItemSi
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
introduce this new signal: make sure the size of the dialog
is final, sinced with the main item and the optional layout
10 matches
Mail list logo
