This revision was automatically updated to reflect the committed changes.
leinir marked an inline comment as done.
Closed by commit R304:eb2e65a882f0: Fix incorrect error detection for missing
knsrc files (authored by leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6340?vs=15742&i
leinir marked an inline comment as done.
leinir added inline comments.
INLINE COMMENTS
> apol wrote in engine.cpp:130
> are you sure the `endl` is necessary?
i am, in fact, reasonably certain it is not required - leftovers are fun, i'll
get rid of that :)
REPOSITORY
R304 KNewStuff
REVISION
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
+1 for proper error messages!
INLINE COMMENTS
> engine.cpp:130
> +emit signalError(i18n("Configuration file exists, but cannot be
> opened: \"%1\"", configfile));
> +qCritical(
leinir created this revision.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This fixes the error detection for knsrc files, which previously would report
missing files only if the di
