This revision was automatically updated to reflect the committed changes.
Closed by commit R308:8389c530e531: Add remote runners over DBus (authored by
davidedmundson).
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6390?vs=16245=18481
REVISION DETAIL
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
BRANCH
dbusrunner
REVISION DETAIL
https://phabricator.kde.org/D6390
To: davidedmundson, #plasma, broulik
Cc: broulik, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
davidedmundson updated this revision to Diff 16245.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.
Kai's comments
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6390?vs=16231=16245
BRANCH
dbusrunner
REVISION DETAIL
davidedmundson marked 9 inline comments as done.
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in dbusrunnertest.cpp:88
> Why are you using `QString` and not `QStringLiteral` all over the place?
because it's in a test...
> broulik wrote in dbusrunner.cpp:109
> We cannot
broulik added a comment.
Cool stuff!
A bunch of nitpicks but then it's good to go.
INLINE COMMENTS
> dbusrunnertest.cpp:45
> +void testMatch();
> +//
> +private:
Remove
> dbusrunnertest.cpp:52
> +{
> +m_process = new QProcess(this);
> +
davidedmundson retitled this revision from "WIP: Add remote runners over DBus"
to "Add remote runners over DBus".
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D6390
To: davidedmundson, #plasma
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
