chinmoyr created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Some methods in file ioslave, `FileProtocol::copy` and FileProtocol::put to
be precise, use file descriptor of source and destination files. So performing
any these operations as root user usin
davidedmundson added a comment.
> The sequence would be, registering service in ioslave, setting euid of the
helper process and sending the file descriptor over user's session bus
I don't fully know this code, but that doesn't sound right.
Your helper is running on the system bus, an
chinmoyr added a comment.
And
In https://phabricator.kde.org/D6709#125610, @davidedmundson wrote:
> > The sequence would be, registering service in ioslave, setting euid of
the helper process and sending the file descriptor over user's session bus
>
> I don't fully know this code
chinmoyr marked an inline comment as done.
chinmoyr added inline comments.
INLINE COMMENTS
> davidedmundson wrote in sharefd.cpp:107
> If this is on the client side, what stops any other (non authorised) client
> listening to here?
It doesn't matter. The job of client is to send the file descri
thiago added a comment.
This class isn't hooked up to anything. It's technically correct as an FD
sender and receiver. What I want to see is how you use it, because that's
extremely important to get right.
I can confirm to you that anonymous namespace sockets do not work on BSDs
(which
elvisangelaccio added a comment.
In https://phabricator.kde.org/D6709#125694, @thiago wrote:
> This class isn't hooked up to anything. It's technically correct as an FD
sender and receiver. What I want to see is how you use it, because that's
extremely important to get right.
I t
chinmoyr updated this revision to Diff 17012.
chinmoyr marked 5 inline comments as done.
chinmoyr added a comment.
std::string -> QString
binded -> bound
setNonBlock() - > SOCK_NONBLOCK
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6709?vs=16732&id=17012
chinmoyr added a task: T6561: Polkit support in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks
Cc: davidedmundson, elvisangelaccio, shortstheory
chinmoyr removed a task: T6561: Polkit support in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks
Cc: davidedmundson, elvisangelaccio, shortstheory
chinmoyr added a task: T6561: Polkit support in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks
Cc: davidedmundson, elvisangelaccio, shortstheory
chinmoyr added a task: T6561: Polkit support in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks
Cc: davidedmundson, elvisangelaccio, shortstheory
chinmoyr removed a task: T6561: Polkit support in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks
Cc: davidedmundson, elvisangelaccio, shortstheory
chinmoyr added a dependent revision: D6197: Add kauth helper to file ioslave.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks
Cc: davidedmundson, elvisangelaccio, shortstheory
chinmoyr added a comment.
@thiago Used FdSender in the function senndFileDescriptor in
https://phabricator.kde.org/D6197 [filehelper.cpp] and FdReceiver in
https://phabricator.kde.org/D6830 [file_unix.cpp]
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinm
chinmoyr added a comment.
ping @thiago
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks
Cc: davidedmundson, elvisangelaccio, shortstheory
chinmoyr updated this revision to Diff 18298.
chinmoyr added a comment.
- add stopListening method to FdReceiver
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6709?vs=17012&id=18298
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6709
AFFECTED FILES
src/ioslaves/
chinmoyr updated this revision to Diff 18502.
chinmoyr added a comment.
- Made changes that were suggested here :
https://codereview.stackexchange.com/questions/173306/sharing-file-descriptor-between-an-under-privileged-and-a-privileged-process-us
CHANGES SINCE LAST UPDATE
https://phabrica
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> sharefd.cpp:32
> +
> +//borrowed from klocalsocket.cpp
> +class KSockaddrUn
Either move it to a common header (if QString everywhere is OK), or use a
differe
chinmoyr updated this revision to Diff 19757.
chinmoyr marked an inline comment as done.
chinmoyr added a comment.
- separated FdReceiver and FdSender
- KMSgHdr -> FDMessageHeader and KSockaddrUn -> SocketAddress and moved them
to private header
- removed `stopListening()` method. Qt can h
chinmoyr updated this revision to Diff 19758.
chinmoyr added a comment.
Added license header
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6709?vs=19757&id=19758
BRANCH
sharefd
REVISION DETAIL
https://phabricator.kde.org/D6709
AFFECTED FILES
src/ioslaves/file/CMakeLists.txt
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Yes `isListening()` would make sense.
The kauth subdir for fdsender.* is ok, it matches what you then do in
https://phabricator.kde.org/D6197 where you actually use that file (well,
yo
chinmoyr updated this revision to Diff 20232.
chinmoyr added a comment.
Changed isValid() -> isListening() in FdReceiver
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6709?vs=19758&id=20232
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6709
AFFECTED FILES
src/i
dfaure accepted this revision.
dfaure added a comment.
This is all ready to push now, right?
Please do, once the 5.39 RC tags are there (should happen today or tomorrow).
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks, dfaure
Cc: df
chinmoyr added a comment.
In https://phabricator.kde.org/D6709#153057, @dfaure wrote:
> This is all ready to push now, right?
>
> Please do, once the 5.39 RC tags are there (should happen today or
tomorrow).
This patch is. I have yet to add the new flag.
BRANCH
master
REVI
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0c2a6811dc50: Add support for sharing file descriptor
between file ioslave and it's KAuth… (authored by chinmoyr).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6709?vs=20232&id=20607#toc
REP
chinmoyr reopened this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks, dfaure
Cc: dfaure, davidedmundson, elvisangelaccio, shortstheory
26 matches
Mail list logo
