albertvaka added a comment.
Mmmm it could be because kio_desktop is a ForwardingSlave, so the entry is
added first by its forwardee (kio_file I think) and then again by kio_desktop
itself?
I'm not sure if what I'm saying even makes sense because I don't really know
how KIO works. Will
albertvaka added a comment.
Reverted the patch. Couldn't figure out what is wrong with it though... I
don't think that "." is being emitted multiple times because of this patch. It
looks more like if kio_desktop was causing listEntries to be called twice.
REPOSITORY
R241 KIO
REVISION
dfaure added a comment.
Difficult to test in kio itself, but for sure testable in the autotest for
kio_desktop (plasma-workspace/kioslave/desktop/tests)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6906
To: albertvaka, #frameworks, elvisangelaccio
Cc: aacid, dfaure
dfaure added a comment.
This commit breaks plasmashell startup for me, with a non-empty desktop:/
2017-07-28T10:51:54 plasmashell(5605)/kf5.kio.core.dirlister
KCoreDirListerCache::slotEntries: KCoreDirListerCache(0x7f6a2002c980)
KIO::ListJob(0x26a9ae0) new entries for QUrl("desktop:/")
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0ac78aa3fba4: Emit a "." UDSEntry when not present, even
on empty directories. (authored by albertvaka).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.
Tested with mtp and it works, thanks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6906
To: albertvaka, #frameworks, elvisangelaccio
albertvaka added a reviewer: elvisangelaccio.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6906
To: albertvaka, #frameworks, elvisangelaccio
albertvaka edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6906
To: albertvaka, #frameworks
albertvaka created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Fixes bug 382046
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6906
AFFECTED FILES
src/core/slavebase.cpp
To: albertvaka, #frameworks