D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

davidedmundson abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: davidedmundson, #plasma, matank Cc: mart, plasma-devel, davidedmundson, ltoscano, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

davidedmundson commandeered this revision. davidedmundson edited reviewers, added: matank; removed: davidedmundson. davidedmundson added a comment. > I can confrim that mart's patch ( https://phabricator.kde.org/D7127) solves the issue. I'll close this . REPOSITORY R242 Plasma Framewor

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

matank added a comment. I can confrim that mart's patch ( https://phabricator.kde.org/D7127) solves the issue. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: matank, #plasma, davidedmundson Cc: mart, plasma-devel, davidedmundson, ltoscan

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

mart added a comment. looking into it, i still think the dialog code is correct. what happens is that someone external resizes the notification window to 0x0 pixels wide right after the componentcomplete event. if as in this patch the dialog is resized explicitly in componentcomplete, that

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

matank added a comment. Calling syncToMainItemSize() in componentComplete() seems to solve the issue , so I checked what is being done in syncToMainItemSize() that affects the issue. I found that resizing the dialog is what seems to resolve the issue so I copied the relevant code from syn

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

davidedmundson added a comment. Can you explain the logic behind adding the code you've added. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: matank, #plasma, davidedmundson Cc: plasma-devel, davidedmundson, ltoscano, #frameworks, ZrenBot

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

matank updated this revision to Diff 17609. matank added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. - Fix issue where notifications will show as 1 pixel line Sets the dialog to his correct size to prevent it showing a

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

davidedmundson added a comment. I've done what I mean here: https://phabricator.kde.org/D7085 Hopefully that will be easier to test. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: matank, #plasma, davidedmundson Cc: davidedmundson, ltos

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This might well hide the issue, but it can't be "correct". It's definitely calling updateTheme twice, which is very expensive. and I'm pretty sure it's syncin

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

broulik retitled this revision from "added back lines to void Dialog::componentComplete() to fix an issue where the notifications will show as 1 pixel line if the primary screen wasn't the most left one." to "Fix issue where notifications will show as 1 pixel line if primary screen wasn't the l