This revision was automatically updated to reflect the committed changes.
Closed by commit R236:0f440836c548: KSqueezedTextLabel: Add isSqueezed() for
convenience (authored by rkflx).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7162?vs=17970&id=18713
dhaumann accepted this revision.
dhaumann added a comment.
Please commit (also https://phabricator.kde.org/D7161)
REPOSITORY
R236 KWidgetsAddons
BRANCH
arcpatch-D7162
REVISION DETAIL
https://phabricator.kde.org/D7162
To: rkflx, #frameworks, dhaumann
Cc: dhaumann
rkflx marked an inline comment as done.
REPOSITORY
R236 KWidgetsAddons
BRANCH
arcpatch-D7162
REVISION DETAIL
https://phabricator.kde.org/D7162
To: rkflx, #frameworks, dhaumann
Cc: dhaumann
rkflx updated this revision to Diff 17970.
rkflx added a comment.
Improve wording to be as elegant as suggested by Dominik.
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7162?vs=17774&id=17970
BRANCH
arcpatch-D7162
REVISION DETAIL
https://phab
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
A good patch, and adding new non-virtual functions is binary compatible. So
this looks good to me.
INLINE COMMENTS
> ksqueezedtextlabel.h:110
> + * i.e. the original text does not
rkflx edited the summary of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7162
To: rkflx, #frameworks
rkflx edited the summary of this revision.
rkflx added a dependency: D7161: KSqueezedTextLabel: Small improvements to API
docs.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7162
To: rkflx, #frameworks
rkflx added a dependent revision: D7163: KSqueezedTextLabel: Add several
autotests.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7162
To: rkflx, #frameworks
rkflx created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
More readable than having to check fullText!=text() again and again.
Will be used in upcoming autotests, but should be useful in general.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
ht
