This revision was automatically updated to reflect the committed changes.
Closed by commit R265:b8641527bb67: Fix icon of KStandardAction::MoveToTrash
(authored by elvisangelaccio).
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7520?vs=20631=20966
ngraham added a comment.
Can we land this?
REPOSITORY
R265 KConfigWidgets
BRANCH
user-trash
REVISION DETAIL
https://phabricator.kde.org/D7520
To: elvisangelaccio, #frameworks, ngraham
Cc: ngraham, andreaska, broulik
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
I support this change, for the additional reason that it's appropriate for
the "move to trash" icon to be black, because red icons are for destructive
changes, and moving something to
andreaska added a comment.
+1
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7520
To: elvisangelaccio, #frameworks
Cc: andreaska, broulik
elvisangelaccio updated this revision to Diff 20631.
elvisangelaccio added a comment.
- Switched from `user-trash` to `trash-empty` (discussed with @andreaska in
person).
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7520?vs=18688=20631
BRANCH
elvisangelaccio added a subscriber: andreaska.
elvisangelaccio added a comment.
@andreaska Is it possible to add a new breeze icon for the move-to-trash
action?
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7520
To: elvisangelaccio, #frameworks
Cc:
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7520#139761, @broulik wrote:
> I do have two somewhat different looking icons in the context menu.
dolphin git master? Make sure you have https://phabricator.kde.org/D6778,
which is what caused the regression
>
broulik added a comment.
I do have two somewhat different looking icons in the context menu.
`user-trash` is for a place, not an action, so this might lead to a colorized
icon showing up in the menu (when using larger icon sizes and/or high dpi)
REPOSITORY
R265 KConfigWidgets
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
It should be different from the DeleteFile icon, otherwise it's not
possible to distinguish them.
TEST PLAN
Open context menu of Dolphin (master) and press Shift.
REPOSITORY
R265
