mandian added a comment.
Great!
Thank you all!
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: ngraham, #breeze, #vdg, jensreuterberg, #frameworks, hein, mandian
Cc: andreask, hein, ngraham, cfeck, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:cb168d3a0bd5: Add missing icon sizes (authored by
ngraham).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7810?vs=22206&id=22307
REVISION DETAIL
https://ph
ngraham commandeered this revision.
ngraham edited reviewers, added: mandian; removed: ngraham.
ngraham added a comment.
Yoink.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: ngraham, #breeze, #vdg, jensreuterberg, #frameworks, hein, mandian
Cc: andrea
mandian added a comment.
This is a patch I wrote when I was packaging MATE desktop. What I only care
is it works well :).
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein
Cc: andreask, h
mandian added a comment.
In https://phabricator.kde.org/D7810#167373, @ngraham wrote:
> You would renounce your copyright in this case.
If it is only a matter of copyright yes, of course :).
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: m
ngraham added a comment.
I'm afraid all commits require a full name and a real, public email address.
Take a look at the git logs and you'll see. They all have real names and email
addresses.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #b
mandian added a comment.
@ngraham the mail is the one you know but please do not expose it in a public
page (I'd like to avoid spam bots). The name I use is the same you know too (I
use this to sign the packages I build for OpenMandirva).
@jensreuterberg sure! I'll ask for help on this t
jensreuterberg added a comment.
Cool! Just please keep an eye out. Pixel-aligning icons is a PITA but
worthwhile so if there is something that ends up blurry please ping
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuter
ngraham added a comment.
I can commit this. @mandian, can you provide a full name? As for an email
address, is mand...@openmailbox.org good?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, h
mandian added a comment.
Even if simplified icons may look better with small size I did not notice any
fuzzy effects in smaller icon.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein
Cc:
jensreuterberg added a comment.
Just as a heads up, check whether the icons become fuzzy in certain sizes on
Mate for example
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein
Cc: andreas
hein accepted this revision.
hein added a comment.
Same.
Do you need someone to commit this for you or do you have access?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham, hein
Cc: andrea
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Looks good to me now. @hein?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham
Cc: andre
mandian updated this revision to Diff 22206.
mandian added a comment.
I cleaned the patch and I included icon-dark too.
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7810?vs=19506&id=22206
REVISION DETAIL
https://phabricator.kde.org/D7810
AFFECTED
ngraham requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham
Cc: andreask, hein, ngraham, cfeck, #frameworks
ngraham added a comment.
Feel free to modify this patch.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham
Cc: andreask, hein, ngraham, cfeck, #frameworks
mandian added a comment.
It like changes for size of icons in MimeTypes is not more needed because the
bug is in caja and not in Breeze theme. Do you prefer I submit a new patch
without these two changes?
INLINE COMMENTS
> hein wrote in index.theme:297
> Hmm why lower this one:
I did this
jensreuterberg added a subscriber: andreask.
jensreuterberg added a comment.
Well the issue is that they are not "scalable" - I mean the goal should
rather be to make them functionable on all sizes but being SVG's means that
they may become misaligned when rendered. (Ie if you make an icon ma
hein added inline comments.
INLINE COMMENTS
> index.theme:297
> MinSize=32
> -MaxSize=48
> +MaxSize=32
>
Hmm why lower this one:
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks, ngraham
Cc: hein, ngr
ngraham added a subscriber: hein.
ngraham added a comment.
@hein, it looks like you might have some context, based on
https://cgit.kde.org/breeze-icons.git/commit/?id=3e3eaaa82169f48ae849b2349c1e981b8b542ba6
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
I ran with this change for a day in stock Neon and couldn't notice any
regressions (or any changes at all, actually).
https://phabricator.kde.org/tag/vdg/ folks, any objections? If I
ngraham edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks
Cc: ngraham, cfeck, #frameworks
ngraham added a reviewer: Frameworks.
ngraham added a comment.
This seems okay to me, but I'm pretty new and I'd really like sign-off from
someone more experienced first.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreute
mandian requested review of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg
Cc: ngraham, cfeck, #frameworks
mandian planned changes to this revision.
mandian added a comment.
Hi ngraham
I added some more details and screenshots to test plan.
Please let me know is more is needed.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensr
mandian edited the summary of this revision.
mandian edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg
Cc: ngraham, cfeck, #frameworks
ngraham added a comment.
Thanks for the patch, Mandian! Can you mention some details of your testing
process in the Test Plan section, and maybe attach some before-and-after
screenshots? Also make sure this change doesn't cause any regressions when
running software in a non-MATE (i.e. Plasma
ngraham added reviewers: VDG, jensreuterberg.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg
Cc: #frameworks
mandian requested review of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze
Cc: #frameworks
mandian planned changes to this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze
Cc: #frameworks
mandian created this revision.
mandian added a project: Breeze.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Add missing icon sizes
TEST PLAN
Add missing scalable icon sizes at index.theme. If not all size are cove
31 matches
Mail list logo
