This revision was automatically updated to reflect the committed changes.
Closed by commit R237:fb15e56857ca: [KConfigGroup] reserve() more and add some
C++11 (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7879?vs=19671=19727#toc
REPOSITORY
R237 KConfig
CHANGES
mwolff accepted this revision.
mwolff added a comment.
ah ok, and since we don't have a proper byte array view yet, there's nothing
you can do (which is sad here!)
the other comments from me where suggestions for further improvements, they
don't need to hold up this patch
REPOSITORY
broulik planned changes to this revision.
broulik added inline comments.
INLINE COMMENTS
> mwolff wrote in kconfiggroup.cpp:187
> use `splitRef` instead, also below
Was my first reflex do to so but `string` confusingly is a `QByteArray`
REPOSITORY
R237 KConfig
REVISION DETAIL
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
it would probably be a good idea to rewrite
`KConfigGroupPrivate::serializeList` to not take a `QVariantList`, but rather
to use a streaming API. I.e. instead of:
void
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D7879
To: broulik, kde-frameworks-devel, dfaure, davidedmundson
Cc: #frameworks
broulik created this revision.
broulik added reviewers: kde-frameworks-devel, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Using initializer_lists for QList we reserve the right amount of memory in
advance
