This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c0c4e4f46ae1: Fix build of breeze-icons on the Android CI
(authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8264?vs=20648=20671#toc
REPOSITORY
R266 Breeze Icons
CHANGES
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
That comment could be a bit more verbose and better placed (i.e. move it next
to `set(BINARY_ICONS_RESOURCE_OPTION_DEFAULT OFF)` and make it something along
"When cross-compiling qrcAlias
apol updated this revision to Diff 20648.
apol added a comment.
Address Kevin's comments
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8264?vs=20641=20648
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8264
AFFECTED FILES
kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:23
> +if (CMAKE_CROSSCOMPILING)
> +set(GENERATE_ICONS_DEFAULT OFF)
> +else()
Better: `GENERATE_ICONS_DEFAULT` ->
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
At the moment we are compiling the tool against android then trying to
execute it, which
