D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 20821. ngraham added a comment. lxr.kde.org showed several programs using Ctrl+, but nothing uses Ctrl+Alt+, REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8296?vs=20738&id=20821 BRANCH master REVISION DETAIL http

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. Darn, that's a shame. Looks like I was holding it wrong. I'll find another shortcut that doesn't conflict. Any suggestions? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: argonel, kfunk, marten, graes

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-15 Thread Eli MacKenzie
argonel added a comment. In https://phabricator.kde.org/D8296, @ngraham wrote: > I chose Ctrl+, because that's the standard shortcut for all (and I do mean all) programs in the macOS world--a standard that has started to trickle into the Windows world as well, because there was previousl

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-15 Thread Kevin Funk
kfunk added a comment. In KDevelop, this is also a really important shortcut for navigating through the source. `Ctrl+,` for jumping to definition, `Ctrl+.` for jumping to declaration. /me wonders if one really needs a shortcut for configuring shortcuts at all. https://lxr.kde.org/sear

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-15 Thread Jonathan Marten
marten added a comment. FYI: KMail uses Ctrl+comma and Ctrl+dot as standard shortcuts for "Collapse all threads" and "Expand all threads" respectively. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: marten, graesslin, broulik

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. Any remaining concerns? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. Unless I'm holding it wrong, https://lxr.kde.org/ident?_i=Comma&_remember=1 doesn't appear show any other uses of Ctrl+, as a keyboard shortcut. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graessli

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D8296#155363, @ngraham wrote: > Sounds good. What's lxr? lxr.kde.org REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. Sounds good. What's lxr? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Martin Flöser
graesslin added a comment. Agree with Kai - this needs good testing that it is not used anywhere. Best by looking through lxr which apps use this framework. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a reviewer: VDG. ngraham added a comment. FWIW, I did some basic testing on that and couldn't find any conflicts among Plasma, KWin, Dolphin, Kate, Konsole, Gwenview, Okular, Konversation, KTorrent, Skanlite. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Kai Uwe Broulik
broulik added a comment. +1 However I fear this might cause "shortcut xyz is ambiguous" messages after update for some users :/ Perhaps also consult VDG / usability REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks Cc: broulik,

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks Cc: #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use Ctrl+, as the standard keyboard shortcut to invoke KDE programs' "Configure " menu items. Right now there is no shortcut defined for th