dfaure added inline comments.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:966
> QTest::newRow("Places - Trash") << m_places->index(2, 0)
> - << QStringLiteral("user-trash-full");
> + << QStringLiteral("user-trash");
>
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3e537c4dd935: Factoring out lists of url data within
KFilePlacesModelTest (authored by franckarrecot, committed by ngraham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
franckarrecot updated this revision to Diff 23023.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=22900=23023
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
franckarrecot added a comment.
this one is landable now that its dependencies are pushed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks
franckarrecot added a comment.
I'll ship it as soon as the commits it's built on will be shipped. Sorry I
rebased this one to renato new commit split so we would avoid conflict if
interlaced commit pushed happend.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
franckarrecot edited the summary of this revision.
franckarrecot added a dependency: D8948: Created an auxiliary function
'KFilePlacesModel::movePlace'.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni,
anthonyfieroni added a comment.
Ship it, it's only tests and looks good.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks
ngraham added a comment.
Is this ready to go in, or do we need some more time for review?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: ervin, ngraham, mlaurent, #frameworks
franckarrecot updated this revision to Diff 22900.
franckarrecot added a comment.
rebased over in review renato 's patches
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=21750=22900
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
franckarrecot commandeered this revision.
franckarrecot edited reviewers, added: mlaurent; removed: franckarrecot.
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: ervin, ngraham, mlaurent, #frameworks
renatoo added a comment.
In https://phabricator.kde.org/D8366#163427, @ngraham wrote:
> Is this dependent on any of the other patches floating around?
Probably not, but that will affect (possible conflicts) with all patches
REVISION DETAIL
https://phabricator.kde.org/D8366
To:
ngraham added a comment.
Is this dependent on any of the other patches floating around?
REVISION DETAIL
https://phabricator.kde.org/D8366
To: mlaurent, renatoo, ervin, franckarrecot
Cc: ervin, ngraham, mlaurent, #frameworks
renatoo accepted this revision.
REVISION DETAIL
https://phabricator.kde.org/D8366
To: mlaurent, renatoo, ervin, franckarrecot
Cc: ervin, ngraham, mlaurent, #frameworks
ervin accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D8366
To: mlaurent, renatoo, ervin, franckarrecot
Cc: ervin, ngraham, mlaurent, #frameworks
mlaurent updated this revision to Diff 21750.
mlaurent added a comment.
Rebase it
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=21646=21750
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
To: mlaurent, renatoo,
mlaurent updated this revision to Diff 21646.
mlaurent added a comment.
Fix typo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=21289=21646
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
To: mlaurent, renatoo,
mlaurent commandeered this revision.
mlaurent edited reviewers, added: franckarrecot; removed: mlaurent.
mlaurent added a comment.
impossible to rebase this one...
I will need to rewrite all this patch
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: mlaurent,
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:177
>
> +static const QStringList initalListOfPlaces()
> +{
Typo: initial
> kfileplacesmodeltest.cpp:182
> +
> +static const
mlaurent added a dependent revision: D8367: Hidding place groups implementation
in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, mlaurent
Cc: mlaurent, #frameworks
franckarrecot updated this revision to Diff 21289.
franckarrecot added a comment.
switch removable after regular devices
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=20973=21289
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
seems ok for me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, mlaurent
Cc: mlaurent, #frameworks
franckarrecot created this revision.
franckarrecot added a reviewer: renatoo.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Instead of reusing the same string lists all over the place
we factor them out, easier to
22 matches
Mail list logo
