This revision was automatically updated to reflect the committed changes.
Closed by commit R245:5885409fb152: Reduce QString creation in Udev checking
(authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8494?vs=21367=21633#toc
REPOSITORY
R245 Solid
CHANGES
broulik added inline comments.
INLINE COMMENTS
> udevmanager.cpp:92
> qDebug() << "Driver:" << device.driver();
> -qDebug() << "Subsystem:" << device.subsystem();
> +qDebug() << "Subsystem:" << subsystem
> qDebug() << "";
This is missing a colon
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D8494
To: davidedmundson, broulik
Cc: #frameworks
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
UdevDevice creates a new QString in every wrapper.
For the most part this makes sense, but we may as well cache a property
if
